mirror of
https://github.com/SerenityOS/serenity
synced 2024-09-19 16:01:40 +00:00
54b9a4ec1e
Previously we would crash the process immediately when a promise violation was found during a syscall. This is error prone, as we don't unwind the stack. This means that in certain cases we can leak resources, like an OwnPtr / RefPtr tracked on the stack. Or even leak a lock acquired in a ScopeLockLocker. To remedy this situation we move the promise violation handling to the syscall handler, right before we return to user space. This allows the code to follow the normal unwind path, and grantees there is no longer any cleanup that needs to occur. The Process::require_promise() and Process::require_no_promises() functions were modified to return ErrorOr<void> so we enforce that the errors are always propagated by the caller.
32 lines
967 B
C++
32 lines
967 B
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <Kernel/Process.h>
|
|
#include <Kernel/Random.h>
|
|
#include <Kernel/UserOrKernelBuffer.h>
|
|
|
|
namespace Kernel {
|
|
|
|
// We don't use the flag yet, but we could use it for distinguishing
|
|
// random source like Linux, unlike the OpenBSD equivalent. However, if we
|
|
// do, we should be able of the caveats that Linux has dealt with.
|
|
ErrorOr<FlatPtr> Process::sys$getrandom(Userspace<void*> buffer, size_t buffer_size, [[maybe_unused]] unsigned flags)
|
|
{
|
|
VERIFY_NO_PROCESS_BIG_LOCK(this);
|
|
TRY(require_promise(Pledge::stdio));
|
|
if (buffer_size > NumericLimits<ssize_t>::max())
|
|
return EINVAL;
|
|
|
|
auto data_buffer = TRY(UserOrKernelBuffer::for_user_buffer(buffer, buffer_size));
|
|
|
|
return TRY(data_buffer.write_buffered<1024>(buffer_size, [&](Bytes bytes) {
|
|
get_good_random_bytes(bytes);
|
|
return bytes.size();
|
|
}));
|
|
}
|
|
|
|
}
|