mirror of
https://github.com/SerenityOS/serenity
synced 2024-10-15 12:23:15 +00:00
264cc76ab4
Before, some loader plugins implemented their own buffering (FLAC&MP3), some didn't require any (WAV), and some didn't buffer at all (QOA). This meant that in practice, while you could load arbitrary amounts of samples from some loader plugins, you couldn't do that with some others. Also, it was ill-defined how many samples you would actually get back from a get_more_samples call. This commit fixes that by introducing a layer of abstraction between the loader and its plugins (because that's the whole point of having the extra class!). The plugins now only implement a load_chunks() function, which is much simpler to implement and allows plugins to play fast and loose with what they actually return. Basically, they can return many chunks of samples, where one chunk is simply a convenient block of samples to load. In fact, some loaders such as FLAC and QOA have separate internal functions for loading exactly one chunk. The loaders *should* load as many chunks as necessary for the sample count to be reached or surpassed (the latter simplifies loading loops in the implementations, since you don't need to know how large your next chunk is going to be; a problem for e.g. FLAC). If a plugin has no problems returning data of arbitrary size (currently WAV), it can return a single chunk that exactly (or roughly) matches the requested sample count. If a plugin is at the stream end, it can also return less samples than was requested! The loader can handle all of these cases and may call into load_chunk multiple times. If the plugin returns an empty chunk list (or only empty chunks; again, they can play fast and loose), the loader takes that as a stream end signal. Otherwise, the loader will always return exactly as many samples as the user requested. Buffering is handled by the loader, allowing any underlying plugin to deal with any weird sample count requirement the user throws at it (looking at you, SoundPlayer!). This (not accidentally!) makes QOA work in SoundPlayer. |
||
|---|---|---|
| .. | ||
| Azure | ||
| CMake | ||
| HeaderCheck | ||
| Lagom | ||
| Screenshots | ||
| ShellCompletions/zsh | ||
| Websites | ||
| analyze-qemu-coverage.sh | ||
| bochsrc | ||
| build-image-extlinux.sh | ||
| build-image-grub.sh | ||
| build-image-limine.sh | ||
| build-image-qemu.sh | ||
| build-manpages-website.sh | ||
| build-native-partition.sh | ||
| build-root-filesystem.sh | ||
| check-ak-test-files.sh | ||
| check-debug-flags.sh | ||
| check-emoji.py | ||
| check-markdown.sh | ||
| check-newlines-at-eof.py | ||
| check-png-sizes.sh | ||
| check-style.py | ||
| check-symbols.sh | ||
| convert-markdown-links.lua | ||
| debug-kernel.sh | ||
| export-argsparser-manpages.sh | ||
| extlinux.conf | ||
| generate-embedded-resource-assembly.sh | ||
| generate-libwasm-spec-test.py | ||
| generate-libwasm-spec-test.sh | ||
| grub-ebr.cfg | ||
| grub-gpt.cfg | ||
| grub-mbr.cfg | ||
| install-ports-tree.sh | ||
| label-pull-requests.js | ||
| limine.cfg | ||
| lint-ci.sh | ||
| lint-clang-format.sh | ||
| lint-commit.sh | ||
| lint-executable-resources.sh | ||
| lint-gml-format.sh | ||
| lint-keymaps.py | ||
| lint-ports.py | ||
| lint-prettier.sh | ||
| lint-python.sh | ||
| lint-shell-scripts.sh | ||
| new-project.sh | ||
| refresh-serenity-qtcreator.sh | ||
| run.sh | ||
| serenity.sh | ||
| serenity_gdb.py | ||
| shell_include.sh | ||
| text-to-cpp-string.sh | ||
| toot-commits.js | ||
| tweet-commits.js | ||