mirror of
https://github.com/SerenityOS/serenity
synced 2024-10-15 12:23:15 +00:00
0acc370f7b
Every single of images's functions then go ahead and error out on CMYKBitmaps for now. (Alternatively, we could make them the low-quality CMYK->RGB conversion that previously happened implicitly, but let's go with this for now.) (With this structure, we could also do something smarter for Vector images in the future.) Here's how this looks: % Build/lagom/bin/image \ -o out.png Tests/LibGfx/test-inputs/jpg/ycck-2111.jpg Runtime error: Can't save CMYK bitmaps yet, convert to RGB first with --convert-to-color-profile % Build/lagom/bin/image \ --convert-to-color-profile serenity-sRGB.icc \ -o out.png Tests/LibGfx/test-inputs/jpg/ycck-2111.jpg Runtime error: No source color space embedded in image. Pass one with --assign-color-profile. % Build/lagom/bin/image \ --assign-color-profile path/to/CMYK/USWebCoatedSWOP.icc \ --convert-to-color-profile serenity-sRGB.icc \ -o out.png Tests/LibGfx/test-inputs/jpg/ycck-2111.jpg Runtime error: Psych, can't convert CMYK bitmaps yet either As usual, serenity-sRGB.icc is from `Build/lagom/bin/icc -n sRGB --reencode-to serenity-sRGB.icc` and the adobe cmyk profiles are available at https://www.adobe.com/support/downloads/iccprofiles/iccprofiles_win.html which ultimately leads to: https://download.adobe.com/pub/adobe/iccprofiles/win/AdobeICCProfilesCS4Win_end-user.zip |
||
---|---|---|
.. | ||
Applets | ||
Applications | ||
BuggieBox | ||
Demos | ||
DevTools | ||
DynamicLoader | ||
Games | ||
Libraries | ||
Services | ||
Shell | ||
Utilities | ||
CMakeLists.txt |