system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 08:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
35496 commits 2 branches 0 tags 516 MiB
Commit graph

14640 commits

Author SHA1 Message Date
Lenny Maiorani d5d795b55e Libraries: Use default constructors/destructors in LibDebug 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani f1c452059c Libraries: Use default constructors/destructors in LibCrypto 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani 59b7e6a213 Libraries: Use default constructors/destructors in LibCpp 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani cb87d13dd5 Libraries: Use default constructors/destructors in LibCoredump 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani ea58b8d927 Libraries: Use default constructors/destructors in LibCore 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani c6dcb12b00 Libraries: Use default constructors/destructors in LibCompress 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani 7030a9b496 Libraries: Use default constructors/destructors in LibChess 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani 11b28c88fc Libraries: Use default constructors/destructors in LibCards 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Lenny Maiorani 2200eb761d Libraries: Use default constructors/destructors in LibAudio 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
 2022-03-10 18:04:26 -08:00
Ali Mohammad Pur 7eafa58af8 Revert "LibPthread: Partially implement pthread_cleanup_(push pop)" 
This reverts commit 5d51e26caf.
The threadlocal Vector was somehow misaligned, causing UBSAN to be sad
about calling a misaligned method (either the dtor or .is_empty()) on
it.
For now, let's revert this and avoid the CI flake.
Fixes #12957.
 2022-03-11 04:12:21 +03:30
Andreas Kling e099960e4d LibWeb: Remove a bunch of no-longer needed #includes 2022-03-11 00:21:49 +01:00
Andreas Kling 5779a910e5 LibWeb: Move hit testing to the painting tree 2022-03-11 00:21:49 +01:00
Andreas Kling ba606d9057 LibWeb: Move PaintingBox to its own .cpp and .h files 2022-03-11 00:21:49 +01:00
Andreas Kling f017c1c064 LibWeb: Make hit testing return a { paintable, offset } 
Everything related to hit testing is better off using the painting tree.
The thing being mousemoved over is a paintable, so let's hand that out
directly instead of the corresponding layout node.
 2022-03-11 00:21:49 +01:00
Andreas Kling cb0c5390ff LibWeb: Move mouse event and label logic from layout to painting tree 
Input events have nothing to do with layout, so let's not send them to
layout nodes.

The job of Paintable starts to become clear. It represents a paintable
item that can be rendered into the viewport, which means it can also
be targeted by the mouse cursor.
 2022-03-11 00:21:49 +01:00
Andreas Kling ed84fbce47 LibWeb: Make Paintable ref-counted 
This will allow us to use a protective NonnullRefPtr to keep paintables
alive while running arbitrary JavaScript in response to events.
 2022-03-11 00:21:49 +01:00
Andreas Kling 702cee3d7c LibWeb: Make Layout::SVGBox inherit from Layout::Box 
This doesn't need anything from Layout::BlockContainer, so let's not
inherit from that.
 2022-03-11 00:21:49 +01:00
Andreas Kling 4d98851aea LibWeb: Generate a TextPaintable for every Layout::TextNode 
This is prep work for moving event handling over to the painting tree.
 2022-03-11 00:21:49 +01:00
Andreas Kling aae356baf1 LibWeb: Port inline elements to the new Paintable system 
This patch adds InlinePaintable which corresponds to Layout::InlineNode.
 2022-03-11 00:21:49 +01:00
Andreas Kling 053766d79c LibWeb: Split Paintable into Paintable and PaintableBox 
To prepare for paintable inline content, we take the basic painting
functionality and hoist it into a base class.
 2022-03-11 00:21:49 +01:00
Andreas Kling 0500dbc3f6 LibWeb: Add Paintable::layout_box() accessor 
Let's move away from accessing the m_layout_box member directly.
 2022-03-11 00:21:49 +01:00
Andreas Kling 9461e44afa LibWeb: Use Layout::Box::paint_box() accessor in more places 2022-03-11 00:21:49 +01:00
Andreas Kling 02b316fd5c LibWeb: Let Paintable perform the painting 
This patch adds a bunch of Paintable subclasses, each corresponding to
the Layout::Node subclasses that had a paint() override. All painting
logic is moved from layout nodes into their corresponding paintables.

Paintables are now created by asking a Layout::Box to produce one:

    static NonnullOwnPtr<Paintable> Layout::Box::create_paintable()

Note that inline nodes still have their painting logic. Since they
are not boxes, and all paintables have a corresponding box, we'll need
to come up with some other solution for them.
 2022-03-11 00:21:49 +01:00
Andreas Kling f6497b64ac LibWeb: Rename Painting::Box => Paintable 
Calling this "Box" made it very confusing to look at code that used both
Layout::Box and Painting::Box. Let's try calling it Paintable instead.
 2022-03-11 00:21:49 +01:00
Andreas Kling 7af03df4c3 LibWeb: Make Painting::Box virtual and add Painting::BoxWithLines 
BlockContainer paint boxes are the only ones that have line boxes
associated, so let's not waste memory on line boxes in all the other
types of boxes.

This also adds Layout::Box::paint_box() and the more tightly typed
Layout::BlockContainer::paint_box() to get at the paint box from the
corresponding layout box.
 2022-03-11 00:21:49 +01:00
Andreas Kling 9f5cbcaad3 LibWeb: Hang StackingContext off of the paint boxes 
Stacking contexts have nothing to do with layout and everything with
painting, so let's keep them in Painting::Box.
 2022-03-11 00:21:49 +01:00
Andreas Kling cc8e429126 LibWeb: Make StackingContext paint functions const 2022-03-11 00:21:49 +01:00
Andreas Kling f0d833a3d7 LibWeb: Move StackingContext and PaintPhase into the Painting namespace 2022-03-11 00:21:49 +01:00
Andreas Kling a4d51b3dc2 LibWeb: Add Painting::Box and move things from Layout::Box into it 
The "paintable" state in Layout::Box was actually not safe to access
until after layout had been performed.

As a first step towards making this harder to mess up accidentally,
this patch moves painting information from Layout::Box to a new class:
Painting::Box. Every layout can have a corresponding paint box, and
it holds the final used metrics determined by layout.

The paint box is created and populated by FormattingState::commit().

I've also added DOM::Node::paint_box() as a convenient way to access
the paint box (if available) of a given DOM node.

Going forward, I believe this will allow us to better separate data
that belongs to layout vs painting, and also open up opportunities
for naturally invalidating caches in the paint box (since it's
reconstituted by every layout.)
 2022-03-11 00:21:49 +01:00
Linus Groh 251f5e8885 LibJS: Use CreateTemporalCalendar in GetBuiltinCalendar 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/f6b3a10
 2022-03-10 23:20:39 +01:00
Linus Groh 7f5b4842f2 LibJS: Replace dead code in ParseTimeZoneOffsetString with an assertion 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/a29c40b
 2022-03-10 23:20:39 +01:00
Linus Groh 55f9733316 LibJS: Add missing check in ParseTemporalInstant 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/baead4d
 2022-03-10 23:20:39 +01:00
Linus Groh f75052ff7c LibJS: Assert CreateTemporalDuration does not throw given correct input 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/881dd22
 2022-03-10 23:20:39 +01:00
Linus Groh d2c2a9bcbf LibJS: Assert CreateTemporalDuration does not throw in Record cases 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/43e954c
 2022-03-10 23:20:39 +01:00
Linus Groh 4553512321 LibJS: Assert CreateTemporalDuration does not throw in trivial cases 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/685e20e
 2022-03-10 23:20:39 +01:00
Linus Groh 54af3a5396 LibJS: Adjust grammar for DateExtendedYear to exclude -000000 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/fb3e656

We lose the custom error message, but it's not the end of the world.
 2022-03-10 23:20:39 +01:00
Linus Groh 68af8649fb LibJS: Follow rules for consuming completion records 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/1c19b96
 2022-03-10 23:20:39 +01:00
Linus Groh 2bae040bc9 LibJS: Remove Sign abstract operation 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/bbc1ebc
 2022-03-10 23:20:39 +01:00
Linus Groh 0d06f3655f LibJS: Move string-parsing code into ToTemporalDurationRecord 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/a68b97b
 2022-03-10 23:20:39 +01:00
Linus Groh 87fb005a8d LibJS: Move IsValidDuration check into ToTemporalDurationRecord 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/00958d0
 2022-03-10 23:20:39 +01:00
Linus Groh 34371b9b61 LibJS: Fix numeric type confusion in ToTemporalRoundingIncrement 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/6e59366
 2022-03-10 23:20:39 +01:00
Linus Groh 4ceff91893 LibJS: Use different variable name in DifferenceISODateTime 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/c32cc4d
 2022-03-10 23:20:39 +01:00
Linus Groh a009e834dc LibJS: Add clarifying assertion to BalanceDurationRelative 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/9a3477a
 2022-03-10 23:20:39 +01:00
Linus Groh 17da627b4c LibJS: Fix "set it to" language to be more explicit 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/de58241
 2022-03-10 23:20:39 +01:00
Linus Groh 4722045e28 LibJS: Do not expose mathematical values to script in Duration methods 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/26a4c4f

No behavioral change as we already did this correctly, but I changed
some implicit JS::Value creations to explicit ones.
 2022-03-10 23:20:39 +01:00
Linus Groh a496868ee5 LibJS: Create Duration Records with their own abstract operations 
This is an editorial change in the Temporal spec.

See:
- https://github.com/tc39/proposal-temporal/commit/387c405
- https://github.com/tc39/proposal-temporal/commit/b203e26
- https://github.com/tc39/proposal-temporal/commit/387c405
 2022-03-10 23:20:39 +01:00
Linus Groh 64e43c89bc LibJS: Remove assertions that are now part of structured headers 
This is an editorial change in the Temporal spec.

See:
- https://github.com/tc39/proposal-temporal/commit/7fbdd28
- https://github.com/tc39/proposal-temporal/commit/f666243
- https://github.com/tc39/proposal-temporal/commit/8c7d066
- https://github.com/tc39/proposal-temporal/commit/307d108
- https://github.com/tc39/proposal-temporal/commit/d9ca402

In practical terms this means we can now get rid of a couple of awkward
assertion steps that were no-ops anyway, since the types are enforced
by the compiler.
 2022-03-10 23:20:39 +01:00
Linus Groh 97bd4cebab LibJS: Refactor return value of RoundDuration 
This is an editorial change in the Temporal spec.

See:
- https://github.com/tc39/proposal-temporal/commit/3641adf
- https://github.com/tc39/proposal-temporal/commit/8ea590c
 2022-03-10 23:20:39 +01:00
Linus Groh bdb13a74b0 LibJS: Describe various kinds of "Duration Records" 
This is an editorial change in the Temporal spec.

See: https://github.com/tc39/proposal-temporal/commit/983902e

We already had these defined as structs, but now they're properly
defined in the spec (opposed to the previous anonymous records), and we
don't have to make up our own names anymore :^)

Note that while we're usually not including 'record' in the name, in
this case the 'Duration Record' has a name clash with the Duration
object. Additionally, later editorial changes introduce CreateFooRecord
AOs, so let's just go with FooRecord structs here.
 2022-03-10 23:20:39 +01:00
Jelle Raaijmakers 2ac415f728 LibGL: Keep track of active matrix and stack 
This simplifies a lot of code in `GLContext` and prevents potential
errors when testing against the current matrix mode.
 2022-03-10 20:20:05 +01:00