system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 12:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Stop creating a redundant lexical scope on function call

Browse source 
We were scoping the arguments twice, first in execute_function_body(),
and then again in enter_scope().
This commit is contained in:
Andreas Kling 2020-12-08 18:04:54 +01:00
parent eb810d14c3
commit fc9e43728b
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/ScriptFunction.cpp
View file

@ -127,7 +127,6 @@ Value ScriptFunction::execute_function_body()
VM::InterpreterExecutionScope scope(*interpreter);
auto& call_frame_args = vm.call_frame().arguments;
ArgumentVector arguments;
for (size_t i = 0; i < m_parameters.size(); ++i) {
auto parameter = m_parameters[i];
Value argument_value;
@ -145,11 +144,10 @@ Value ScriptFunction::execute_function_body()
} else {
argument_value = js_undefined();
}
arguments.append({ parameter.name, argument_value });
vm.current_scope()->put_to_scope(parameter.name, { argument_value, DeclarationKind::Var });
}
return interpreter->execute_statement(global_object(), m_body, move(arguments), ScopeType::Function);
return interpreter->execute_statement(global_object(), m_body, {}, ScopeType::Function);
}
Value ScriptFunction::call()