system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 02:26:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Userland: Resolve unused-but-set-varaible warnings

Browse source 
These are almost always bugs, so enable globally.

Remove unused counter variables in SystemMonitor and disk_benchmark.
This commit is contained in:
Andrew Kaster 2022-01-03 02:52:02 -07:00 committed by Brian Gianforcaro
parent d809637023
commit f8ea9cd64e
3 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CMakeLists.txt
View file

@ -200,7 +200,6 @@ elseif (CMAKE_CXX_COMPILER_ID MATCHES "Clang$")
add_compile_options(-Wno-implicit-const-int-float-conversion)
add_compile_options(-Wno-null-pointer-subtraction)
add_compile_options(-Wno-unneeded-internal-declaration)
add_compile_options(-Wno-unused-but-set-variable)
add_compile_options(-Wno-unused-const-variable)
add_compile_options(-Wno-unused-function)
add_compile_options(-Wno-unused-private-field)

3
Userland/Applications/SystemMonitor/ProcessModel.cpp
View file

@ -334,7 +334,6 @@ void ProcessModel::update()
auto all_processes = Core::ProcessStatisticsReader::get_all(m_proc_all);
HashTable<int> live_tids;
u64 sum_time_scheduled = 0, sum_time_scheduled_kernel = 0;
u64 total_time_scheduled_diff = 0;
if (all_processes.has_value()) {
if (m_has_total_scheduled_time)
@ -382,8 +381,6 @@ void ProcessModel::update()
state.cpu_percent = 0;
state.priority = thread.priority;
state.state = thread.state;
sum_time_scheduled += thread.time_user + thread.time_kernel;
sum_time_scheduled_kernel += thread.time_kernel;
auto& thread_data = *m_threads.ensure(thread.tid, [] { return make<Thread>(); });
thread_data.previous_state = move(thread_data.current_state);
thread_data.current_state = move(state);

2
Userland/Utilities/disk_benchmark.cpp
View file

@ -147,7 +147,7 @@ Optional<Result> benchmark(const String& filename, int file_size, int block_size
auto timer = Core::ElapsedTimer::start_new();
ssize_t total_written = 0;
for (ssize_t j = 0; j < file_size; j += block_size) {
while (total_written < file_size) {
auto nwritten = write(fd, buffer.data(), block_size);
if (nwritten < 0) {
perror("write");