system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-16 12:52:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

WindowServer: don't send resize on resolution change unless needed

Browse source 
fixes #2575

The extra ResizeEvent would be handled after on_rect_change, and would
reset the size of main_widget to what it was before the resize.

Bonus: Less unnecessary events.
This commit is contained in:
Peter Elliott 2020-06-28 18:14:41 -06:00 committed by Andreas Kling
parent 951a429268
commit f833362536
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Services/WindowServer/Window.cpp
View file

@ -520,11 +520,20 @@ void Window::recalculate_rect()
return;
auto old_rect = m_rect;
if (m_tiled != WindowTileType::None)
bool send_event = true;
if (m_tiled != WindowTileType::None) {
set_rect(tiled_rect(m_tiled));
else if (is_maximized())
} else if (is_maximized()) {
set_rect(WindowManager::the().maximized_window_rect(*this));
Core::EventLoop::current().post_event(*this, make<ResizeEvent>(old_rect, m_rect));
} else if (type() == WindowType::Desktop) {
set_rect(WindowManager::the().desktop_rect());
} else {
send_event = false;
}
if (send_event) {
Core::EventLoop::current().post_event(*this, make<ResizeEvent>(old_rect, m_rect));
}
}
void Window::add_child_window(Window& child_window)

2
Services/WindowServer/WindowManager.cpp
View file

@ -142,8 +142,6 @@ bool WindowManager::set_resolution(int width, int height)
});
if (success) {
for_each_window([](Window& window) {
if (window.type() == WindowType::Desktop)
window.set_rect(WindowManager::the().desktop_rect());
window.recalculate_rect();
return IterationDecision::Continue;
});