system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 10:36:24 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

HexEditor: Prefer enum class to enum for FindDialog::OptionId

Browse source
This commit is contained in:
Tim Ledbetter 2024-02-07 22:25:53 +00:00 committed by Jelle Raaijmakers
parent b330d83be4
commit f742334b93
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Applications/HexEditor/FindDialog.cpp
View file

@ -24,8 +24,8 @@ struct Option {
static constexpr Array<Option, 2> options = {
{
{ "ASCII String"sv, OPTION_ASCII_STRING, true, true },
{ "Hex value"sv, OPTION_HEX_VALUE, true, false },
{ "ASCII String"sv, OptionId::AsciiString, true, true },
{ "Hex value"sv, OptionId::HexValue, true, false },
}
};
@ -77,9 +77,9 @@ ErrorOr<ByteBuffer> FindDialog::process_input(StringView text_value, OptionId op
VERIFY(!text_value.is_empty());
switch (opt) {
case OPTION_ASCII_STRING:
case OptionId::AsciiString:
return ByteBuffer::copy(text_value.bytes());
case OPTION_HEX_VALUE: {
case OptionId::HexValue: {
auto text_no_spaces = text_value.replace(" "sv, ""sv, ReplaceMode::All);
return decode_hex(text_no_spaces);
}

10
Userland/Applications/HexEditor/FindDialog.h
View file

@ -11,10 +11,10 @@
#include <AK/String.h>
#include <LibGUI/Dialog.h>
enum OptionId {
OPTION_INVALID = -1,
OPTION_ASCII_STRING,
OPTION_HEX_VALUE
enum class OptionId {
Invalid = -1,
AsciiString,
HexValue
};
class FindDialog : public GUI::Dialog {
@ -41,5 +41,5 @@ private:
bool m_find_all { false };
String m_text_value;
OptionId m_selected_option { OPTION_INVALID };
OptionId m_selected_option { OptionId::Invalid };
};