system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-06 17:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Fix old object numeric key test now that toString() is correct

Browse source
This commit is contained in:
Stephan Unverwerth 2020-12-27 01:27:10 +01:00 committed by Andreas Kling
parent d3524f47a0
commit f603128e55
2 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/Value.cpp
View file

@ -134,15 +134,13 @@ static String double_to_string(double d)
auto number_string = number_string_builder.to_string();
// HACK: (sunverwerth) I'm not sure how the ECMAScript spec deals with numbers that
// can not be exactly represented in IEE754 so I'm cutting off after the 15th fractional digit.
// Otherwise 3.14.toString() would come out as "3.140000000000000124344978758017532527446746826171875"
// Chrome and Firefox output the expected "3.14" here
// FIXME: Remove this hack.
// FIXME: Instead find the shortest round-trippable representation.
// Remove decimals after the 15th position
if (end_index > intpart_end + 15) {
exponent += end_index - intpart_end - 15;
end_index = intpart_end + 15;
}
// HACK end
// remove leading zeroes
while (start_index < end_index && number_string[start_index] == '0') {

3
Libraries/LibJS/Tests/object-basic.js
View file

@ -87,8 +87,7 @@ describe("correct behavior", () => {
test("floating point keys", () => {
const math = { 3.14: "pi" };
expect(math["3.14"]).toBe("pi");
// FIXME: Floating point literals are coerced to i32
// expect(math[3.14]).toBe("pi");
expect(math[3.14]).toBe("pi");
});
test("keywords as property keys", () => {