system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 01:55:07 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Table wrappers should not be ignored in auto height calculation

Browse source 
Though table wrappers are anonymous block containers (because
TableWrapper is inherited from BlockContainer) with no lines they
should not be skipped in block auto height calculation.
This commit is contained in:
Aliaksandr Kalenik 2023-01-29 15:47:37 +03:00 committed by Andreas Kling
parent 9e5fd95e44
commit f43f4feb1e
3 changed files with 35 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
Tests/LibWeb/Layout/expected/table-auto-height.txt Normal file
View file

@ -0,0 +1,23 @@
InitialContainingBlock <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x60.9375 children: not-inline
BlockContainer <body> at (10,10) content-size 780x42.9375 children: not-inline
BlockContainer <div> at (11,11) content-size 778x19.46875 children: not-inline
TableWrapper <(anonymous)> at (11,11) content-size 29.15625x19.46875 children: not-inline
TableBox <(anonymous)> at (11,11) content-size 29.15625x19.46875 children: not-inline
TableRowBox <(anonymous)> at (11,11) content-size 29.15625x19.46875 children: not-inline
TableCellBox <span> at (12,12) content-size 27.15625x17.46875 children: inline
line 0 width: 27.15625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [12,12 27.15625x17.46875]
"foo"
TextNode <#text>
BlockContainer <div> at (11,32.46875) content-size 778x19.46875 children: not-inline
TableWrapper <(anonymous)> at (11,32.46875) content-size 29.640625x19.46875 children: not-inline
TableBox <(anonymous)> at (11,32.46875) content-size 29.640625x19.46875 children: not-inline
TableRowBox <(anonymous)> at (11,32.46875) content-size 29.640625x19.46875 children: not-inline
TableCellBox <span> at (12,33.46875) content-size 27.640625x17.46875 children: inline
line 0 width: 27.640625, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 3, rect: [12,33.46875 27.640625x17.46875]
"bar"
TextNode <#text>
BlockContainer <(anonymous)> at (10,52.9375) content-size 780x0 children: inline
TextNode <#text>

11
Tests/LibWeb/Layout/input/table-auto-height.html Normal file
View file

@ -0,0 +1,11 @@
<!DOCTYPE html><html><head><style>
body {
font-family: 'SerenitySans';
}
* {
border: 1px solid black;
}
span {
display: table-cell;
}
</style></head><body><div><span>foo</span></div><div><span>bar</span></div>

2
Userland/Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -433,7 +433,7 @@ CSSPixels BlockFormattingContext::compute_auto_height_for_block_level_element(Bo
auto const& child_box_state = m_state.get(*child_box);
// Ignore anonymous block containers with no lines. These don't count as in-flow block boxes.
if (child_box->is_anonymous() && child_box->is_block_container() && child_box_state.line_boxes.is_empty())
if (!child_box->is_table_wrapper() && child_box->is_anonymous() && child_box->is_block_container() && child_box_state.line_boxes.is_empty())
continue;
auto margin_bottom = m_margin_state.current_collapsed_margin();