system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 04:13:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Support the yy{/,-}mm{/,-}dd hh:mm format for Date

Browse source 
Required by a UK news website for loading a Piano configuration.
This is presumably configuration for piano.io Analytics.
This commit is contained in:
Luke Wilde 2023-03-23 03:22:25 +00:00 committed by Andreas Kling
parent 5c8be3b072
commit f0d0459c3e
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/DateConstructor.cpp
View file

@ -147,10 +147,12 @@ static double parse_simplified_iso8601(DeprecatedString const& iso_8601)
return time_clip(time_ms);
}
static constexpr AK::Array<StringView, 3> extra_formats = {
static constexpr AK::Array<StringView, 5> extra_formats = {
"%a %b %e %T %z %Y"sv,
"%m/%e/%Y"sv,
"%m/%e/%Y %R %z"sv,
"%Y/%m/%e %R"sv,
"%Y-%m-%e %R"sv,
};
static double parse_date_string(DeprecatedString const& date_string)
@ -163,6 +165,7 @@ static double parse_date_string(DeprecatedString const& date_string)
// Parse formats of this type: "Wed Apr 17 23:08:53 +0000 2019"
// And: "4/17/2019"
// And: "12/05/2022 10:00 -0800"
// And: "2014/11/14 13:05" or "2014-11-14 13:05"
// FIXME: Exactly what timezone and which additional formats we should support is unclear.
// Both Chrome and Firefox seem to support "4/17/2019 11:08 PM +0000" with most parts
// being optional, however this is not clearly documented anywhere.

6
Userland/Libraries/LibJS/Tests/builtins/Date/Date.parse.js
View file

@ -84,3 +84,9 @@ test("mm/dd/yy hh:mm timezone-offset extension", () => {
expect(Date.parse("12/05/2022 10:00 -0800")).toBe(1670263200000);
expect(Date.parse("01/03/2023 10:00 -0800")).toBe(1672768800000);
});
test("yy{/,-}mm{/,-}dd hh:mm extension", () => {
// Example from a UK news website.
expect(Date.parse("2014/11/14 13:05")).toBe(1415970300000);
expect(Date.parse("2014-11-14 13:05")).toBe(1415970300000);
});