From eda2a2f5da50b593b9c0c136c27a671cfcadbcaa Mon Sep 17 00:00:00 2001 From: Kemal Zebari Date: Mon, 8 May 2023 13:53:29 -0700 Subject: [PATCH] AK: Remove `must_set()` from `JsonArray` Due to 582c55a, both `must_set()` and `set()` should be providing the same behavior. Not only is that a reason to remove `must_set()`, but it also performs erroneous behavior since it inserts an element at a specified index instead of modifying an element at that index. --- AK/JsonArray.h | 1 - Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/AK/JsonArray.h b/AK/JsonArray.h index 1154925568..9b732036bb 100644 --- a/AK/JsonArray.h +++ b/AK/JsonArray.h @@ -62,7 +62,6 @@ public: [[nodiscard]] JsonValue take(size_t index) { return m_values.take(index); } void must_append(JsonValue value) { m_values.append(move(value)); } - void must_set(size_t index, JsonValue value) { m_values.insert(index, move(value)); } void clear() { m_values.clear(); } ErrorOr append(JsonValue value) { return m_values.try_append(move(value)); } diff --git a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp index 8a2819128a..ee2d782364 100644 --- a/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp +++ b/Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp @@ -203,7 +203,7 @@ static ErrorOr clone_an_object(JS::Realm& re [&](JsonArray& array) { // NOTE: If this was a JS array, only indexed properties would be serialized anyway. if (name.is_number()) - array.must_set(name.as_number(), cloned_property_result.value()); + array.set(name.as_number(), cloned_property_result.value()); }, [&](JsonObject& object) { object.set(name.to_string(), cloned_property_result.value());