system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 00:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Kernel/Syscalls: Allow root to ptrace any process

Browse source 
Previously root (euid=0) was not able to ptrace any dumpable process
as expected. This change fixes this.
This commit is contained in:
Uku Loskit 2023-11-05 23:09:46 +02:00 committed by Andreas Kling
parent 8c7b393939
commit ecbb1df01b
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Syscalls/ptrace.cpp
View file

@ -42,8 +42,7 @@ static ErrorOr<FlatPtr> handle_ptrace(Kernel::Syscall::SC_ptrace_params const& p
auto peer_credentials = peer->process().credentials();
auto caller_credentials = caller.credentials();
if ((peer_credentials->uid() != caller_credentials->euid())
|| (peer_credentials->uid() != peer_credentials->euid())) // Disallow tracing setuid processes
if (!caller_credentials->is_superuser() && ((peer_credentials->uid() != caller_credentials->euid()) || (peer_credentials->uid() != peer_credentials->euid()))) // Disallow tracing setuid processes
return EACCES;
if (!peer->process().is_dumpable())