system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-05 23:14:54 +00:00
Code Issues Projects Releases Wiki Activity

AK: Move move() into the "std" namespace

Browse Source 
This makes GCC emit warnings about redundant and pessimizing moves.
It also allows static analyzers like clang-tidy to detect common bugs
like use-after-move.
This commit is contained in:
Andreas Kling 2021-03-17 16:31:17 +01:00
parent f59ad2dc57
commit ea81dc13cf
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
AK/StdLibExtras.h
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2021, Andreas Kling <kling@serenityos.org>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@ -33,6 +33,20 @@ constexpr unsigned round_up_to_power_of_two(unsigned value, unsigned power_of_tw
return ((value - 1) & ~(power_of_two - 1)) + power_of_two;
}
namespace std {
// NOTE: This is in the "std" namespace since some compiler features rely on it.
template<typename T>
constexpr T&& move(T& arg)
{
return static_cast<T&&>(arg);
}
}
using std::move;
namespace AK {
template<typename T>
@ -77,12 +91,6 @@ constexpr T ceil_div(T a, U b)
return result;
}
template<typename T>
constexpr T&& move(T& arg)
{
return static_cast<T&&>(arg);
}
template<typename T, typename U>
inline void swap(T& a, U& b)
{
@ -622,7 +630,6 @@ using AK::MakeSigned;
using AK::MakeUnsigned;
using AK::max;
using AK::min;
using AK::move;
using AK::RemoveConst;
using AK::swap;
using AK::UnderlyingType;