system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-06 00:51:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ladybird: Fix reloading functionality

Browse source 
Previously, reloading went back to the first page loaded by
WebView::load() or WebView::load_html(), as they are the only methods
that modify m_url, which is what the reload loaded. Now we handle
reloads in Tab.cpp by simply loading the last entry in the m_history.
This commit is contained in:
Baitinq 2022-11-09 00:35:55 +01:00 committed by Andrew Kaster
parent 0b15fd4a12
commit e80147afba
3 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Ladybird/Tab.cpp
View file

@ -159,7 +159,8 @@ void Tab::home()
void Tab::reload()
{
view().reload();
m_is_history_navigation = true;
view().load(m_history.current().url.to_string());
}
void Tab::location_edit_return_pressed()

5
Ladybird/WebContentView.cpp
View file

@ -79,11 +79,6 @@ WebContentView::~WebContentView()
{
}
void WebContentView::reload()
{
load(m_url);
}
void WebContentView::load(AK::URL const& url)
{
m_url = url;

1
Ladybird/WebContentView.h
View file

@ -53,7 +53,6 @@ public:
void load(AK::URL const&);
void load_html(StringView html, AK::URL const&);
void reload();
Function<void(Gfx::IntPoint const& screen_position)> on_context_menu_request;
Function<void(const AK::URL&, String const& target, unsigned modifiers)> on_link_click;