system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 12:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibSymbolication: Fix integer overflow when calculating region addresses

Browse source
This commit is contained in:
Gunnar Beutner 2021-07-27 08:29:42 +02:00 committed by Andreas Kling
parent b10a86d463
commit e3d2ca6bd2
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibSymbolication/Symbolication.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Checked.h>
#include <AK/JsonArray.h>
#include <AK/JsonObject.h>
#include <AK/JsonValue.h>
@ -192,7 +193,12 @@ Vector<Symbol> symbolicate_thread(pid_t pid, pid_t tid)
for (auto address : stack) {
const RegionWithSymbols* found_region = nullptr;
for (auto& region : regions) {
if (address >= region.base && address < (region.base + region.size)) {
FlatPtr region_end;
if (Checked<FlatPtr>::addition_would_overflow(region.base, region.size))
region_end = NumericLimits<FlatPtr>::max();
else
region_end = region.base + region.size;
if (address >= region.base && address < region_end) {
found_region = &region;
break;
}