mirror of
https://github.com/SerenityOS/serenity
synced 2024-09-06 17:06:31 +00:00
AK: Fix all quadratic-time append-loops over ByteBuffer
This commit is contained in:
parent
0ebcc99e12
commit
e147d0b572
|
@ -289,6 +289,12 @@ private:
|
||||||
|
|
||||||
NEVER_INLINE ErrorOr<void> try_ensure_capacity_slowpath(size_t new_capacity)
|
NEVER_INLINE ErrorOr<void> try_ensure_capacity_slowpath(size_t new_capacity)
|
||||||
{
|
{
|
||||||
|
// When we are asked to raise the capacity by very small amounts,
|
||||||
|
// the caller is perhaps appending very little data in many calls.
|
||||||
|
// To avoid copying the entire ByteBuffer every single time,
|
||||||
|
// we raise the capacity exponentially, by a factor of roughly 1.5.
|
||||||
|
// This is most noticable in Lagom, where kmalloc_good_size is just a no-op.
|
||||||
|
new_capacity = max(new_capacity, (capacity() * 3) / 2);
|
||||||
new_capacity = kmalloc_good_size(new_capacity);
|
new_capacity = kmalloc_good_size(new_capacity);
|
||||||
auto* new_buffer = (u8*)kmalloc(new_capacity);
|
auto* new_buffer = (u8*)kmalloc(new_capacity);
|
||||||
if (!new_buffer)
|
if (!new_buffer)
|
||||||
|
|
|
@ -33,6 +33,14 @@ TEST_CASE(equality_operator)
|
||||||
EXPECT_EQ(d == d, true);
|
EXPECT_EQ(d == d, true);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
BENCHMARK_CASE(append)
|
||||||
|
{
|
||||||
|
ByteBuffer bb;
|
||||||
|
for (size_t i = 0; i < 1000000; ++i) {
|
||||||
|
bb.append(static_cast<u8>(i));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* FIXME: These `negative_*` tests should cause precisely one compilation error
|
* FIXME: These `negative_*` tests should cause precisely one compilation error
|
||||||
* each, and always for the specified reason. Currently we do not have a harness
|
* each, and always for the specified reason. Currently we do not have a harness
|
||||||
|
|
Loading…
Reference in a new issue