system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 08:40:44 +00:00
Code Issues Projects Releases Wiki Activity

AK: Fix all quadratic-time append-loops over ByteBuffer

Browse Source
This commit is contained in:
Ben Wiederhake 2023-01-09 15:31:27 +01:00 committed by Jelle Raaijmakers
parent 0ebcc99e12
commit e147d0b572
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
AK/ByteBuffer.h
View File

@ -289,6 +289,12 @@ private:
NEVER_INLINE ErrorOr<void> try_ensure_capacity_slowpath(size_t new_capacity)
{
// When we are asked to raise the capacity by very small amounts,
// the caller is perhaps appending very little data in many calls.
// To avoid copying the entire ByteBuffer every single time,
// we raise the capacity exponentially, by a factor of roughly 1.5.
// This is most noticable in Lagom, where kmalloc_good_size is just a no-op.
new_capacity = max(new_capacity, (capacity() * 3) / 2);
new_capacity = kmalloc_good_size(new_capacity);
auto* new_buffer = (u8*)kmalloc(new_capacity);
if (!new_buffer)

8
Tests/AK/TestByteBuffer.cpp
View File

@ -33,6 +33,14 @@ TEST_CASE(equality_operator)
EXPECT_EQ(d == d, true);
}
BENCHMARK_CASE(append)
{
ByteBuffer bb;
for (size_t i = 0; i < 1000000; ++i) {
bb.append(static_cast<u8>(i));
}
}
/*
* FIXME: These `negative_*` tests should cause precisely one compilation error
* each, and always for the specified reason. Currently we do not have a harness