system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 18:46:18 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Use type-correct hashing and formatting functions for pixels

Browse source 
1. Don't use double_hash. This is not for doubles, as its name implies.

2. Specialize traits and formatters using the underlying DistinctNumeric
   type of Web::DevicePixels and Web::CSSPixels.
This commit is contained in:
Timothy Flynn 2023-01-20 15:23:17 -05:00 committed by Jelle Raaijmakers
parent 60b56892ca
commit dbc04bbf1b
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/PixelUnits.h
View file

@ -127,7 +127,7 @@ template<>
struct Traits<Web::CSSPixels> : public GenericTraits<Web::CSSPixels> {
static unsigned hash(Web::CSSPixels const& key)
{
return double_hash(key.value());
return Traits<Web::CSSPixels::Type>::hash(key.value());
}
static bool equals(Web::CSSPixels const& a, Web::CSSPixels const& b)
@ -140,7 +140,7 @@ template<>
struct Traits<Web::DevicePixels> : public GenericTraits<Web::DevicePixels> {
static unsigned hash(Web::DevicePixels const& key)
{
return double_hash(key.value());
return Traits<Web::DevicePixels::Type>::hash(key.value());
}
static bool equals(Web::DevicePixels const& a, Web::DevicePixels const& b)
@ -150,18 +150,18 @@ struct Traits<Web::DevicePixels> : public GenericTraits<Web::DevicePixels> {
};
template<>
struct Formatter<Web::CSSPixels> : Formatter<float> {
struct Formatter<Web::CSSPixels> : Formatter<Web::CSSPixels::Type> {
ErrorOr<void> format(FormatBuilder& builder, Web::CSSPixels const& value)
{
return Formatter<float>::format(builder, value.value());
return Formatter<Web::CSSPixels::Type>::format(builder, value.value());
}
};
template<>
struct Formatter<Web::DevicePixels> : Formatter<float> {
struct Formatter<Web::DevicePixels> : Formatter<Web::DevicePixels::Type> {
ErrorOr<void> format(FormatBuilder& builder, Web::DevicePixels const& value)
{
return Formatter<float>::format(builder, value.value());
return Formatter<Web::DevicePixels::Type>::format(builder, value.value());
}
};