system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 10:36:24 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Kernel: Check kernel symbol's name length matches searched name

Browse source 
The current implementation would only check the first name.length()
characters match, which means any kernel symbol that the provided name
is a prefix of would match, instead of the actual matching symbol.

This commit fixes that by using StringView::operator==() for the
comparison, which already checks the equality correctly.
This commit is contained in:
Idan Horowitz 2021-04-28 21:05:35 +03:00 committed by Andreas Kling
parent c9f3cc6dcc
commit d9f7b29273
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Kernel/KSyms.cpp
View file

@ -32,8 +32,9 @@ static u8 parse_hex_digit(char nibble)
FlatPtr address_for_kernel_symbol(const StringView& name)
{
for (size_t i = 0; i < s_symbol_count; ++i) {
if (!strncmp(name.characters_without_null_termination(), s_symbols[i].name, name.length()))
return s_symbols[i].address;
const auto& symbol = s_symbols[i];
if (name == symbol.name)
return symbol.address;
}
return 0;
}