system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-30 05:05:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

CrashReporter: Don't update window progress if window has been closed

Browse source 
This prevents a crash that could happen if crash reporter was closed
while generating a crash report.
This commit is contained in:
Tim Ledbetter 2024-05-15 08:47:25 +01:00 committed by Nico Weber
parent 860804baa5
commit ce11613677
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Applications/CrashReporter/main.cpp
View file

@ -317,15 +317,17 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
save_backtrace_button.set_enabled(false);
(void)Threading::BackgroundAction<ThreadBacktracesAndCpuRegisters>::construct(
[&, coredump = move(coredump)](auto&) {
[&, window = window->make_weak_ptr<GUI::Window>(), coredump = move(coredump)](auto&) {
ThreadBacktracesAndCpuRegisters results;
size_t thread_index = 0;
coredump->for_each_thread_info([&](auto& thread_info) {
results.thread_backtraces.append(build_backtrace(*coredump, thread_info, thread_index, [&](size_t frame_index, size_t frame_count) {
app->event_loop().deferred_invoke([&, frame_index, frame_count] {
window->set_progress(100.0f * (float)(frame_index + 1) / (float)frame_count);
progressbar.set_value(frame_index + 1);
progressbar.set_max(frame_count);
if (auto strong_window = window.strong_ref(); strong_window && strong_window->is_visible()) {
strong_window->set_progress(100.0f * (float)(frame_index + 1) / (float)frame_count);
progressbar.set_value(frame_index + 1);
progressbar.set_max(frame_count);
}
});
}));
results.thread_cpu_registers.append(build_cpu_registers(thread_info, thread_index));