system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Add String::operator==(StringView)

Browse source 
Comparing a String to a StringView would instantiate a temporary
String just for the comparison. Let's not do that. :^)
This commit is contained in:
Andreas Kling 2019-08-24 22:28:42 +02:00
parent b020a5e7ce
commit cd8278e489
2 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
AK/AKString.h
View file

@ -133,6 +133,9 @@ public:
bool operator==(const String&) const;
bool operator!=(const String& other) const { return !(*this == other); }
bool operator==(const StringView&) const;
bool operator!=(const StringView& other) const { return !(*this == other); }
bool operator<(const String&) const;
bool operator<(const char*) const;
bool operator>=(const String& other) const { return !(*this < other); }

14
AK/String.cpp
View file

@ -19,6 +19,20 @@ bool String::operator==(const String& other) const
return !memcmp(characters(), other.characters(), length());
}
bool String::operator==(const StringView& other) const
{
if (!m_impl)
return !other.m_characters;
if (!other.m_characters)
return false;
if (length() != other.length())
return false;
return !memcmp(characters(), other.characters_without_null_termination(), length());
}
bool String::operator<(const String& other) const
{
if (!m_impl)