system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-06 17:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Implement scrollIntoView with 'center' block position

Browse source 
This fixes a crash on:

https://docs.github.com/en/get-started/learning-about-github/githubs-plans
This commit is contained in:
Shannon Booth 2024-05-19 11:14:42 +12:00 committed by Andreas Kling
parent b3c8974718
commit ccdf82c9be
3 changed files with 31 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/scroll-into-view-center.txt Normal file
View file

@ -0,0 +1 @@
The page has been scrolled to y: 800

29
Tests/LibWeb/Text/input/scroll-into-view-center.html Normal file
View file

@ -0,0 +1,29 @@
<script src="include.js"></script>
<style>
body {
margin: 0;
}
#box {
width: 200px;
height: 200px;
background-color: magenta;
}
</style>
<div style="height: 1000px"></div>
<div style="margin-left: 500px" onclick="clickHandler(event)" id="box"></div>
<div style="height: 1000px"></div>
<script>
function clickHandler(event) {
document.getElementById("box").scrollIntoView({ block: "center" });
}
asyncTest(done => {
document.addEventListener("scroll", event => {
println("The page has been scrolled to y: " + window.scrollY);
done();
});
document.getElementById("box").dispatchEvent(new Event("click"));
});
</script>

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -1672,7 +1672,7 @@ static ErrorOr<void> scroll_an_element_into_view(DOM::Element& target, Bindings:
}
// 3. Otherwise, if block is "center", then align the center of target bounding border box with the center of scrolling box in scrolling box’s block flow direction.
else if (block == Bindings::ScrollLogicalPosition::Center) {
TODO();
y = element_edge_a + (element_height / 2) - (scrolling_box_height / 2);
}
// 4. Otherwise, block is "nearest":
else {