Various things:

- putch syscall now directly calls Console::putChar().
- /proc/summary includes some info about kmalloc stats.
- Syscall entry is guarded by a simple spinlock.
- Unmap regions for crashed tasks.
This commit is contained in:
Andreas Kling 2018-10-23 15:19:02 +02:00
parent c80a1f39ce
commit ccd15e0590
5 changed files with 82 additions and 8 deletions

View file

@ -12,9 +12,9 @@ public:
virtual ssize_t read(byte* buffer, size_t size) override;
virtual ssize_t write(const byte* data, size_t size) override;
private:
void putChar(char);
private:
const byte m_rows { 25 };
const byte m_columns { 80 };
byte m_cursorRow { 0 };

View file

@ -21,7 +21,7 @@ bool ProcFileSystem::initialize()
cli();
auto tasks = Task::allTasks();
char* buffer;
auto stringImpl = StringImpl::createUninitialized(tasks.size() * 64, buffer);
auto stringImpl = StringImpl::createUninitialized(tasks.size() * 128, buffer);
memset(buffer, 0, stringImpl->length());
char* ptr = buffer;
ptr += ksprintf(ptr, "PID OWNER STATE NAME\n");
@ -33,6 +33,7 @@ bool ProcFileSystem::initialize()
task->state(),
task->name().characters());
}
ptr += ksprintf(ptr, "kmalloc: alloc: %u / free: %u\n", sum_alloc, sum_free);
*ptr = '\0';
sti();
return ByteBuffer::copy((byte*)buffer, ptr - buffer);

View file

@ -1,7 +1,7 @@
#include "i386.h"
#include "VGA.h"
#include "Task.h"
#include "Syscall.h"
#include "Console.h"
extern "C" void syscall_entry();
extern "C" void syscall_ISR();
@ -38,23 +38,92 @@ asm(
" iret\n"
);
static inline dword CAS(dword* mem, dword newval, dword oldval)
{
dword ret;
asm volatile(
"cmpxchgl %2, %1"
:"=a"(ret), "=m"(*mem)
:"r"(newval), "m"(*mem), "0"(oldval));
return ret;
}
class SpinLock {
public:
SpinLock()
{
}
~SpinLock()
{
unlock();
}
void lock()
{
volatile dword count = 0;
for (;;) {
if (CAS(&m_lock, 1, 0) == 1)
return;
++count;
}
if (count)
kprintf("waited %u in %s\n",count, current->name().characters());
}
void unlock()
{
// barrier();
m_lock = 0;
}
private:
dword m_lock { 0 };
};
class Locker {
public:
explicit Locker(SpinLock& l)
: m_lock(l)
{
m_lock.lock();
}
~Locker()
{
unlock();
}
void unlock()
{
m_lock.unlock();
}
private:
SpinLock& m_lock;
};
namespace Syscall {
static SpinLock* s_lock;
void initialize()
{
s_lock = new SpinLock;
registerUserCallableInterruptHandler(0x80, syscall_ISR);
kprintf("syscall: int 0x80 handler installed\n");
}
DWORD handle(DWORD function, DWORD arg1, DWORD arg2, DWORD arg3)
{
Locker locker(*s_lock);
switch (function) {
case Syscall::Yield:
yield();
break;
case Syscall::PutCharacter:
kprintf("%c", arg1 & 0xff);
Console::the().putChar(arg1 & 0xff);
break;
case Syscall::Sleep:
//kprintf("syscall: sleep(%d)\n", arg1);
@ -73,8 +142,8 @@ DWORD handle(DWORD function, DWORD arg1, DWORD arg2, DWORD arg3)
return current->sys$read((int)arg1, (void*)arg2, (size_t)arg3);
case Syscall::PosixSeek:
// FIXME: This has the wrong signature, should be like lseek()
kprintf("syscall: seek(%d, %p, %u)\n", arg1, arg2, arg3);
return current->sys$read((int)arg1, (void*)arg2, (size_t)arg3);
kprintf("syscall: seek(%d, %d)\n", arg1, arg2);
return current->sys$seek((int)arg1, (int)arg2);
case Syscall::PosixKill:
kprintf("syscall: kill(%d, %d)\n", arg1, arg2);
return current->sys$kill((pid_t)arg1, (int)arg2);
@ -85,6 +154,8 @@ DWORD handle(DWORD function, DWORD arg1, DWORD arg2, DWORD arg3)
case Syscall::PosixGetpid:
return current->sys$getpid();
case Syscall::PosixExit:
cli();
locker.unlock();
current->sys$exit((int)arg1);
ASSERT_NOT_REACHED();
return 0;

View file

@ -366,6 +366,8 @@ void Task::sys$exit(int status)
setState(Exiting);
MemoryManager::the().unmapRegionsForTask(*this);
s_tasks->remove(this);
if (!scheduleNewTask()) {
@ -382,7 +384,7 @@ void Task::taskDidCrash(Task* crashedTask)
{
// NOTE: This is called from an excepton handler, so interrupts are disabled.
crashedTask->setState(Crashing);
// crashedTask->dumpRegions();
crashedTask->dumpRegions();
s_tasks->remove(crashedTask);

Binary file not shown.