system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 20:33:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibGUI: Stop duplicating mouse events of cursor tracking widget

Browse source 
Previously we didn't always return when there was an automatic cursor
tracking widget. This meant for certain events e.g. a MouseUp over
the tracking widget, the event would be fired twice on the same widget
(once on `m_automatic_cursor_tracking_widget` then again on
`result.widget` outside the if).

Fixes #16737
This commit is contained in:
MacDue 2023-01-03 20:01:12 +00:00 committed by Andreas Kling
parent 25a60f988a
commit c7ab6daf26
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGUI/Window.cpp
View file

@ -385,8 +385,8 @@ void Window::handle_mouse_event(MouseEvent& event)
} else {
auto is_hovered = m_automatic_cursor_tracking_widget.ptr() == result.widget.ptr();
set_hovered_widget(is_hovered ? m_automatic_cursor_tracking_widget.ptr() : nullptr);
return;
}
return;
}
set_hovered_widget(result.widget);
if (event.buttons() != 0 && !m_automatic_cursor_tracking_widget)