system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 08:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Libraries: Use default constructors/destructors in LibCompress

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 09:06:40 -07:00 committed by Brian Gianforcaro
parent 7030a9b496
commit c6dcb12b00
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCompress/Gzip.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
@ -225,10 +225,6 @@ GzipCompressor::GzipCompressor(OutputStream& stream)
{
}
GzipCompressor::~GzipCompressor()
{
}
size_t GzipCompressor::write(ReadonlyBytes bytes)
{
BlockHeader header;

4
Userland/Libraries/LibCompress/Gzip.h
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2020, the SerenityOS developers.
* Copyright (c) 2020-2022, the SerenityOS developers.
* Copyright (c) 2021, Idan Horowitz <idan.horowitz@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
@ -82,7 +82,7 @@ private:
class GzipCompressor final : public OutputStream {
public:
GzipCompressor(OutputStream&);
~GzipCompressor();
~GzipCompressor() = default;
size_t write(ReadonlyBytes) override;
bool write_or_error(ReadonlyBytes) override;