system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-16 06:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Assign an underlying type to generated CSS enums

Browse source 
I'm *pretty* sure that even a u32 would be overkill but you never know
with CSS specs.
This commit is contained in:
Sam Atkins 2022-04-13 20:28:17 +01:00 committed by Andreas Kling
parent c50661067d
commit c66da0f2cb
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSEnums.cpp
View file

@ -62,7 +62,19 @@ enum class ValueID;
enum_generator.set("name:titlecase", title_casify(name));
enum_generator.set("name:snakecase", snake_casify(name));
enum_generator.appendln("enum class @name:titlecase@ {");
// Find the smallest possible type to use.
auto member_max_value = members.size() - 1;
if (NumericLimits<u8>::max() >= member_max_value) {
enum_generator.set("enum_type", "u8");
} else if (NumericLimits<u16>::max() >= member_max_value) {
enum_generator.set("enum_type", "u16");
} else if (NumericLimits<u32>::max() >= member_max_value) {
enum_generator.set("enum_type", "u32");
} else {
enum_generator.set("enum_type", "u64");
}
enum_generator.appendln("enum class @name:titlecase@ : @enum_type@ {");
for (auto& member : members.values()) {
auto member_name = member.to_string();