system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 01:55:07 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Make HashTable::operator=(HashTable&&) clear the moved-from table

Browse source 
This is consistent with how other AK containers behave when moved from.
This commit is contained in:
Andreas Kling 2021-05-30 14:23:23 +02:00
parent 259822493f
commit c584421592
2 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
AK/HashTable.h
View file

@ -110,7 +110,8 @@ public:
HashTable& operator=(HashTable&& other) noexcept
{
swap(*this, other);
HashTable temporary { move(other) };
swap(*this, temporary);
return *this;
}

25
Tests/AK/TestHashTable.cpp
View file

@ -16,6 +16,31 @@ TEST_CASE(construct)
EXPECT_EQ(IntTable().size(), 0u);
}
TEST_CASE(basic_move)
{
HashTable<int> foo;
foo.set(1);
EXPECT_EQ(foo.size(), 1u);
auto bar = move(foo);
EXPECT_EQ(bar.size(), 1u);
EXPECT_EQ(foo.size(), 0u);
foo = move(bar);
EXPECT_EQ(bar.size(), 0u);
EXPECT_EQ(foo.size(), 1u);
}
TEST_CASE(move_is_not_swap)
{
HashTable<int> foo;
foo.set(1);
HashTable<int> bar;
bar.set(2);
foo = move(bar);
EXPECT(foo.contains(2));
EXPECT(!bar.contains(1));
EXPECT_EQ(bar.size(), 0u);
}
TEST_CASE(populate)
{
HashTable<String> strings;