From c2e13764bcaac63ffb515c32ec6d05be02845f4a Mon Sep 17 00:00:00 2001 From: Kyle Lanmon Date: Thu, 14 Mar 2024 16:01:03 -0500 Subject: [PATCH] GamesSettings: Use on_change callback for resetting cards defaults --- Userland/Applications/GamesSettings/CardSettingsWidget.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Userland/Applications/GamesSettings/CardSettingsWidget.cpp b/Userland/Applications/GamesSettings/CardSettingsWidget.cpp index 5f2fac201f..f7bdac9b5c 100644 --- a/Userland/Applications/GamesSettings/CardSettingsWidget.cpp +++ b/Userland/Applications/GamesSettings/CardSettingsWidget.cpp @@ -124,11 +124,7 @@ void CardSettingsWidget::reset_default_values() { m_background_color_input->set_color(Gfx::Color::from_rgb(0x008000)); set_card_back_image_path(default_card_back_image_path); - // FIXME: `set_text()` on a combobox doesn't trigger the `on_change` callback, but it probably should! - // Until then, we have to manually tell the preview to update. m_card_front_images_combo_box->set_text(default_card_front_image_set); - Cards::CardPainter::the().set_front_images_set_name(card_front_images_set_name()); - m_preview_frame->update(); } bool CardSettingsWidget::set_card_back_image_path(StringView path)