system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 02:26:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK+Userland: Rename Array::front/back to first/last

Browse source 
This is the name that is used for every other collection type so let's
be consistent.
This commit is contained in:
Sam Atkins 2022-04-06 12:05:26 +01:00 committed by Andreas Kling
parent 359365a06a
commit c0ca6e470f
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
AK/Array.h
View file

@ -34,11 +34,11 @@ struct Array {
return __data[index];
}
[[nodiscard]] constexpr T const& front() const { return at(0); }
[[nodiscard]] constexpr T& front() { return at(0); }
[[nodiscard]] constexpr T const& first() const { return at(0); }
[[nodiscard]] constexpr T& first() { return at(0); }
[[nodiscard]] constexpr T const& back() const requires(Size > 0) { return at(Size - 1); }
[[nodiscard]] constexpr T& back() requires(Size > 0) { return at(Size - 1); }
[[nodiscard]] constexpr T const& last() const requires(Size > 0) { return at(Size - 1); }
[[nodiscard]] constexpr T& last() requires(Size > 0) { return at(Size - 1); }
[[nodiscard]] constexpr bool is_empty() const { return size() == 0; }

2
Userland/Applets/Audio/main.cpp
View file

@ -199,7 +199,7 @@ private:
Gfx::Bitmap& choose_bitmap_from_volume()
{
if (m_audio_muted)
return *m_volume_level_bitmaps.back().bitmap;
return *m_volume_level_bitmaps.last().bitmap;
for (auto& pair : m_volume_level_bitmaps) {
if (m_audio_volume >= pair.volume_threshold)

2
Userland/Libraries/LibAudio/MP3Tables.h
View file

@ -115,7 +115,7 @@ constexpr auto MakeMixedScaleFactorBandArray()
Array<ScaleFactorBand, N> result {};
constexpr auto long_bands = MakeLongScaleFactorBandArray<sizes_long>();
constexpr auto short_bands = MakeShortScaleFactorBandArray<sizes_short, long_bands.back().end + 1>();
constexpr auto short_bands = MakeShortScaleFactorBandArray<sizes_short, long_bands.last().end + 1>();
for (size_t i = 0; i < long_bands.size(); i++) {
result[i] = long_bands[i];

2
Userland/Libraries/LibGL/Tex/Texture2D.h
View file

@ -34,7 +34,7 @@ public:
MipMap const& mipmap(unsigned lod) const
{
if (lod >= m_mipmaps.size())
return m_mipmaps.back();
return m_mipmaps.last();
return m_mipmaps.at(lod);
}