From bc4dadde322db0d12589d6d132b347380e42d8d9 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 18 Oct 2023 07:05:36 -0400 Subject: [PATCH] Meta: Add a note about resolving PR review comments --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 341b4a85e6..1c87935bb4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -57,6 +57,7 @@ Nobody is perfect, and sometimes we mess things up. That said, here are some goo * Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work"). * Write your commit messages in proper English, with care and punctuation. * Amend your existing commits when adding changes after a review, where relevant. +* Mark each review comment as "resolved" after pushing a fix with the requested changes. * Add your personal copyright line to files when making substantive changes. (Optional but encouraged!) * Check the spelling of your code, comments and commit messages. * If you have images that go along with your code, run `optipng -strip all` on them to optimize and strip away useless metadata - this can reduce file size from multiple kilobytes to a couple hundred bytes.