system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

AK: Do not append string bytes as code points when title-casing a string

Browse source 
By appending individual bytes as code points, we were "breaking apart"
multi-byte UTF-8 code points. This now behaves the same way as the
invert_case() helper in StringUtils.
This commit is contained in:
Timothy Flynn 2022-10-20 08:44:18 -04:00 committed by Linus Groh
parent 66e424a084
commit b9dc0b7d1b
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/StringUtils.cpp
View file

@ -465,9 +465,9 @@ String to_titlecase(StringView str)
for (auto ch : str) {
if (next_is_upper)
builder.append_code_point(to_ascii_uppercase(ch));
builder.append(to_ascii_uppercase(ch));
else
builder.append_code_point(to_ascii_lowercase(ch));
builder.append(to_ascii_lowercase(ch));
next_is_upper = ch == ' ';
}

2
Tests/AK/TestStringUtils.cpp
View file

@ -387,4 +387,6 @@ TEST_CASE(to_titlecase)
EXPECT_EQ(AK::StringUtils::to_titlecase("foo bar"sv), "Foo Bar"sv);
EXPECT_EQ(AK::StringUtils::to_titlecase("foo bar"sv), "Foo Bar"sv);
EXPECT_EQ(AK::StringUtils::to_titlecase(" foo bar "sv), " Foo Bar "sv);
EXPECT_EQ(AK::StringUtils::to_titlecase("\xc3\xa7"sv), "\xc3\xa7"sv); // U+00E7 LATIN SMALL LETTER C WITH CEDILLA
EXPECT_EQ(AK::StringUtils::to_titlecase("\xe1\x80\x80"sv), "\xe1\x80\x80"sv); // U+1000 MYANMAR LETTER KA
}