From b8f1e1bed2a77aadfb7b23a37ff4e3015a68dc23 Mon Sep 17 00:00:00 2001 From: Moustafa Raafat Date: Mon, 14 Nov 2022 18:25:18 +0000 Subject: [PATCH] Everywhere: Remove unnecessary AK and Detail namespace scoping --- AK/BinaryBufferWriter.h | 2 +- AK/Concepts.h | 2 +- AK/Forward.h | 2 +- AK/HashTable.h | 2 +- AK/IntrusiveRedBlackTree.h | 2 +- AK/StdLibExtraDetails.h | 2 +- AK/StdLibExtras.h | 4 ++-- AK/Stream.h | 4 ++-- AK/StringBuilder.h | 2 +- AK/UFixedBigInt.h | 4 ++-- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/AK/BinaryBufferWriter.h b/AK/BinaryBufferWriter.h index db7ea998de..abbade998a 100644 --- a/AK/BinaryBufferWriter.h +++ b/AK/BinaryBufferWriter.h @@ -19,7 +19,7 @@ public: } template - requires(AK::Detail::IsTriviallyConstructible) T& append_structure() + requires(IsTriviallyConstructible) T& append_structure() { VERIFY((reinterpret_cast(m_target.data()) + m_offset) % alignof(T) == 0); VERIFY(m_offset + sizeof(T) <= m_target.size()); diff --git a/AK/Concepts.h b/AK/Concepts.h index f419990e2d..8b193d5127 100644 --- a/AK/Concepts.h +++ b/AK/Concepts.h @@ -46,7 +46,7 @@ template typename S> concept SpecializationOf = IsSpecializationOf; template -concept AnyString = Detail::IsConstructible; +concept AnyString = IsConstructible; template concept HashCompatible = IsHashCompatible, Detail::Decay>; diff --git a/AK/Forward.h b/AK/Forward.h index 31561e6de4..d3987b9377 100644 --- a/AK/Forward.h +++ b/AK/Forward.h @@ -16,7 +16,7 @@ class ByteBuffer; } class Bitmap; -using ByteBuffer = AK::Detail::ByteBuffer<32>; +using ByteBuffer = Detail::ByteBuffer<32>; class Error; class GenericLexer; class IPv4Address; diff --git a/AK/HashTable.h b/AK/HashTable.h index e2eee6d78a..b855eb881e 100644 --- a/AK/HashTable.h +++ b/AK/HashTable.h @@ -293,7 +293,7 @@ public: { if (m_capacity == 0) return; - if constexpr (!Detail::IsTriviallyDestructible) { + if constexpr (!IsTriviallyDestructible) { for (auto* bucket : *this) bucket->~T(); } diff --git a/AK/IntrusiveRedBlackTree.h b/AK/IntrusiveRedBlackTree.h index 9dbf2b24dc..ae20c16f02 100644 --- a/AK/IntrusiveRedBlackTree.h +++ b/AK/IntrusiveRedBlackTree.h @@ -24,7 +24,7 @@ struct ExtractIntrusiveRedBlackTreeTypes { }; template> -using SubstitutedIntrusiveRedBlackTreeNode = IntrusiveRedBlackTreeNode::Type>; +using SubstitutedIntrusiveRedBlackTreeNode = IntrusiveRedBlackTreeNode::Type>; template V::*member> class IntrusiveRedBlackTree : public BaseRedBlackTree { diff --git a/AK/StdLibExtraDetails.h b/AK/StdLibExtraDetails.h index 446cf5adfe..b2a0bcf77a 100644 --- a/AK/StdLibExtraDetails.h +++ b/AK/StdLibExtraDetails.h @@ -582,7 +582,7 @@ inline constexpr bool IsSpecializationOf, U> = true; template struct __Decay { - typedef Detail::RemoveCVReference type; + typedef RemoveCVReference type; }; template struct __Decay { diff --git a/AK/StdLibExtras.h b/AK/StdLibExtras.h index 0600889309..9f8a265ed4 100644 --- a/AK/StdLibExtras.h +++ b/AK/StdLibExtras.h @@ -36,13 +36,13 @@ namespace std { // NOLINT(cert-dcl58-cpp) Names in std to aid tools // NOTE: These are in the "std" namespace since some compilers and static analyzers rely on it. template -constexpr T&& forward(AK::Detail::RemoveReference& param) +constexpr T&& forward(RemoveReference& param) { return static_cast(param); } template -constexpr T&& forward(AK::Detail::RemoveReference&& param) noexcept +constexpr T&& forward(RemoveReference&& param) noexcept { static_assert(!IsLvalueReference, "Can't forward an rvalue as an lvalue."); return static_cast(param); diff --git a/AK/Stream.h b/AK/Stream.h index 45e6257703..c4269da90e 100644 --- a/AK/Stream.h +++ b/AK/Stream.h @@ -60,7 +60,7 @@ private: namespace AK { -class InputStream : public virtual AK::Detail::Stream { +class InputStream : public virtual Detail::Stream { public: // Reads at least one byte unless none are requested or none are available. Does nothing // and returns zero if there is already an error. @@ -81,7 +81,7 @@ public: virtual bool discard_or_error(size_t count) = 0; }; -class OutputStream : public virtual AK::Detail::Stream { +class OutputStream : public virtual Detail::Stream { public: virtual size_t write(ReadonlyBytes) = 0; virtual bool write_or_error(ReadonlyBytes) = 0; diff --git a/AK/StringBuilder.h b/AK/StringBuilder.h index 9bde5b102d..78790d9c22 100644 --- a/AK/StringBuilder.h +++ b/AK/StringBuilder.h @@ -93,7 +93,7 @@ private: u8 const* data() const { return m_buffer.data(); } static constexpr size_t inline_capacity = 256; - AK::Detail::ByteBuffer m_buffer; + Detail::ByteBuffer m_buffer; }; } diff --git a/AK/UFixedBigInt.h b/AK/UFixedBigInt.h index 22ae0129f8..2066c8376a 100644 --- a/AK/UFixedBigInt.h +++ b/AK/UFixedBigInt.h @@ -25,9 +25,9 @@ requires(sizeof(T) >= sizeof(u64) && IsUnsigned) class UFixedBigInt; // constexpr inline bool Detail::IsIntegral> = true; template -constexpr inline bool Detail::IsUnsigned> = true; +constexpr inline bool IsUnsigned> = true; template -constexpr inline bool Detail::IsSigned> = false; +constexpr inline bool IsSigned> = false; template struct NumericLimits> {