From b5c682bc2ea59576aeca49a19466b94b905eb936 Mon Sep 17 00:00:00 2001 From: Matthew Olsson Date: Sun, 2 Jun 2024 10:09:30 -0700 Subject: [PATCH] LibWeb: Copy the keyframes in KeyframeEffect's copy constructor --- .../WebAnimations/misc/keyframe-effect-cloning.txt | 2 ++ .../WebAnimations/misc/keyframe-effect-cloning.html | 12 ++++++++++++ .../Libraries/LibWeb/Animations/KeyframeEffect.cpp | 2 +- 3 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 Tests/LibWeb/Text/expected/WebAnimations/misc/keyframe-effect-cloning.txt create mode 100644 Tests/LibWeb/Text/input/WebAnimations/misc/keyframe-effect-cloning.html diff --git a/Tests/LibWeb/Text/expected/WebAnimations/misc/keyframe-effect-cloning.txt b/Tests/LibWeb/Text/expected/WebAnimations/misc/keyframe-effect-cloning.txt new file mode 100644 index 0000000000..09a341626e --- /dev/null +++ b/Tests/LibWeb/Text/expected/WebAnimations/misc/keyframe-effect-cloning.txt @@ -0,0 +1,2 @@ +anim count: 1 +keyframe: {"offset":null,"computedOffset":1,"easing":"linear","composite":"auto","marginLeft":"10px"} diff --git a/Tests/LibWeb/Text/input/WebAnimations/misc/keyframe-effect-cloning.html b/Tests/LibWeb/Text/input/WebAnimations/misc/keyframe-effect-cloning.html new file mode 100644 index 0000000000..dea3a17ee2 --- /dev/null +++ b/Tests/LibWeb/Text/input/WebAnimations/misc/keyframe-effect-cloning.html @@ -0,0 +1,12 @@ + + + diff --git a/Userland/Libraries/LibWeb/Animations/KeyframeEffect.cpp b/Userland/Libraries/LibWeb/Animations/KeyframeEffect.cpp index 822a2778de..7bf2dc9256 100644 --- a/Userland/Libraries/LibWeb/Animations/KeyframeEffect.cpp +++ b/Userland/Libraries/LibWeb/Animations/KeyframeEffect.cpp @@ -706,8 +706,8 @@ WebIDL::ExceptionOr> KeyframeEffect::construct_ // - effect target, effect->m_target_element = source->target(); - // FIXME: // - keyframes, + effect->m_keyframes = source->m_keyframes; // - composite operation, and effect->set_composite(source->composite());