system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-03 06:35:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use Core::Timer for cursor blink timer in BrowsingContext

Browse source 
Using `Core::Timer` that doesn't implicitly convert callback to
`JS::SafeFunction` fixes the bug when `BrowsingContext` is never
destroyed because of cyclic dependency between callback and
`BrowsingContext`.
This commit is contained in:
Aliaksandr Kalenik 2023-08-19 16:19:52 +02:00 committed by Andreas Kling
parent dfb5ba0e2c
commit b2b99aba95
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/BrowsingContext.cpp
View file

@ -439,14 +439,14 @@ BrowsingContext::BrowsingContext(Page& page, HTML::NavigableContainer* container
, m_event_handler({}, *this)
, m_container(container)
{
m_cursor_blink_timer = Platform::Timer::create_repeating(500, [this] {
m_cursor_blink_timer = Core::Timer::create_repeating(500, [this] {
if (!is_focused_context())
return;
if (m_cursor_position.node() && m_cursor_position.node()->layout_node()) {
m_cursor_blink_state = !m_cursor_blink_state;
m_cursor_position.node()->layout_node()->set_needs_display();
}
});
}).release_value_but_fixme_should_propagate_errors();
}
BrowsingContext::~BrowsingContext() = default;

2
Userland/Libraries/LibWeb/HTML/BrowsingContext.h
View file

@ -321,7 +321,7 @@ private:
JS::GCPtr<HTML::WindowProxy> m_window_proxy;
DOM::Position m_cursor_position;
RefPtr<Platform::Timer> m_cursor_blink_timer;
RefPtr<Core::Timer> m_cursor_blink_timer;
bool m_cursor_blink_state { false };
HashTable<ViewportClient*> m_viewport_clients;