From aee66e011954b4a071edfca0e5ebf124da5f0ffb Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 11 Oct 2018 01:00:15 +0200 Subject: [PATCH] Avoid modifying Object::m_children while iterating it. --- Widgets/Object.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Widgets/Object.cpp b/Widgets/Object.cpp index 70d96b2c8c..57216928a2 100644 --- a/Widgets/Object.cpp +++ b/Widgets/Object.cpp @@ -13,9 +13,9 @@ Object::~Object() { if (m_parent) m_parent->removeChild(*this); - for (auto* child : m_children) { + auto childrenToDelete = std::move(m_children); + for (auto* child : childrenToDelete) delete child; - } } void Object::event(Event& event)