system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Remove operators && and || from DistinctNumeric

Browse source 
These don't do short-circuit evaluation, and so I ran into some
some very subtle side-effects when converting code to DistinctNumeric.

In code like this:

    MyDistinctNumeric n;
    if (n && check_thing(n))
        return;

There would be no short-circuit evaluation if the return type of
check_thing() was implicitly convertible to MyDistinctNumeric.

Ran into this while making Ext2FS::GroupIndex a DistinctNumeric.
This commit is contained in:
Andreas Kling 2021-02-12 13:27:48 +01:00
parent e00f519cdd
commit acf341862a
2 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
AK/DistinctNumeric.h
View file

@ -150,16 +150,6 @@ public:
static_assert(Bool, "'!a' is only available for DistinctNumeric types with 'Bool'.");
return !this->m_value;
}
bool operator&&(const Self& other) const
{
static_assert(Bool, "'a&&b' is only available for DistinctNumeric types with 'Bool'.");
return this->m_value && other.m_value;
}
bool operator||(const Self& other) const
{
static_assert(Bool, "'a||b' is only available for DistinctNumeric types with 'Bool'.");
return this->m_value || other.m_value;
}
// Intentionally don't define `operator bool() const` here. C++ is a bit
// overzealos, and whenever there would be a type error, C++ instead tries
// to convert to a common int-ish type first. `bool` is int-ish, so

9
AK/Tests/TestDistinctNumeric.cpp
View file

@ -123,13 +123,6 @@ TEST_CASE(operator_bool)
EXPECT_EQ(!a, true);
EXPECT_EQ(!b, false);
EXPECT_EQ(!c, false);
EXPECT_EQ(a && b, false);
EXPECT_EQ(a && c, false);
EXPECT_EQ(b && c, true);
EXPECT_EQ(a || a, false);
EXPECT_EQ(a || b, true);
EXPECT_EQ(a || c, true);
EXPECT_EQ(b || c, true);
}
TEST_CASE(operator_flags)
@ -233,8 +226,6 @@ TEST_CASE(composability)
EXPECT_EQ(a >= b, false);
// Bool
EXPECT_EQ(!a, true);
EXPECT_EQ(a && b, false);
EXPECT_EQ(a || b, true);
// Flags
EXPECT_EQ(a & b, GeneralNumeric(0));
EXPECT_EQ(a | b, GeneralNumeric(1));