system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 12:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

PDFViewer: Show page numbers in Outline TreeView

Browse source 
This is a nice addition to the outline view, which previously simply
displayed the titles of each section. Pages are shown in the first
column, but the tree is expanded via the second column, where the title
is.
This commit is contained in:
Rodrigo Tobar 2022-12-17 13:39:27 +08:00 committed by Andreas Kling
parent c76564b533
commit aaa210e6db
3 changed files with 42 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
Userland/Applications/PDFViewer/OutlineModel.cpp
View file

@ -5,8 +5,17 @@
*/
#include "OutlineModel.h"
#include <AK/Assertions.h>
#include <AK/NonnullRefPtrVector.h>
#include <LibGUI/ModelRole.h>
#include <LibGfx/Font/FontDatabase.h>
#include <LibGfx/TextAlignment.h>
enum Columns {
Page,
Title,
_Count
};
ErrorOr<NonnullRefPtr<OutlineModel>> OutlineModel::create(NonnullRefPtr<PDF::OutlineDict> const& outline)
{
@ -41,9 +50,14 @@ int OutlineModel::row_count(const GUI::ModelIndex& index) const
return static_cast<int>(outline_item->children.size());
}
int OutlineModel::tree_column() const
{
return Columns::Title;
}
int OutlineModel::column_count(const GUI::ModelIndex&) const
{
return 1;
return Columns::_Count;
}
GUI::Variant OutlineModel::data(const GUI::ModelIndex& index, GUI::ModelRole role) const
@ -53,13 +67,36 @@ GUI::Variant OutlineModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol
switch (role) {
case GUI::ModelRole::Display:
return outline_item->title;
switch (index.column()) {
case Columns::Title:
return outline_item->title;
case Columns::Page: {
auto maybe_page_number = outline_item->dest.page;
if (maybe_page_number.has_value()) {
return maybe_page_number.release_value();
}
return {};
}
default:
VERIFY_NOT_REACHED();
}
case GUI::ModelRole::Icon:
if (m_open_outline_items.contains(outline_item))
return m_open_item_icon;
return m_closed_item_icon;
default:
return {};
case GUI::ModelRole::TextAlignment:
switch (index.column()) {
case Columns::Title:
return Gfx::TextAlignment::CenterLeft;
case Columns::Page:
return Gfx::TextAlignment::CenterRight;
default:
VERIFY_NOT_REACHED();
}
}
}

1
Userland/Applications/PDFViewer/OutlineModel.h
View file

@ -18,6 +18,7 @@ public:
virtual int row_count(const GUI::ModelIndex&) const override;
virtual int column_count(const GUI::ModelIndex&) const override;
virtual int tree_column() const override;
virtual GUI::Variant data(const GUI::ModelIndex& index, GUI::ModelRole role) const override;
virtual GUI::ModelIndex parent_index(const GUI::ModelIndex&) const override;
virtual GUI::ModelIndex index(int row, int column, const GUI::ModelIndex&) const override;

2
Userland/Applications/PDFViewer/SidebarWidget.cpp
View file

@ -22,6 +22,8 @@ SidebarWidget::SidebarWidget()
m_outline_tree_view = outline_container.add<GUI::TreeView>();
m_outline_tree_view->set_activates_on_selection(true);
m_outline_tree_view->set_should_fill_selected_rows(true);
m_outline_tree_view->set_selection_behavior(GUI::AbstractView::SelectionBehavior::SelectRows);
auto& thumbnails_container = tab_bar.add_tab<GUI::Widget>("Thumbnails");
thumbnails_container.set_layout<GUI::VerticalBoxLayout>();