system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Destroy navigable containers not inserted into document tree

Browse source 
This change fixes the bug where navigable containers related to a
document, but not present in the tree, were never destroyed.

Fixes https://github.com/SerenityOS/serenity/issues/21364
This commit is contained in:
Aliaksandr Kalenik 2023-10-07 18:41:14 +02:00 committed by Andreas Kling
parent 61b6146d5e
commit a86531809e
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -2714,12 +2714,11 @@ void Document::destroy()
// When a frame element stops being an active frame element, the user agent must destroy a child navigable given the element.
// A frame element is said to be an active frame element when it is in a document tree and its node document's browsing context is non-null.
for_each_shadow_including_descendant([&](DOM::Node& node) {
if (is<HTML::NavigableContainer>(node)) {
verify_cast<HTML::NavigableContainer>(node).destroy_the_child_navigable();
for (auto& navigable_container : HTML::NavigableContainer::all_instances()) {
if (&navigable_container->document() == this) {
navigable_container->destroy_the_child_navigable();
}
return IterationDecision::Continue;
});
}
// 7. Set document's node navigable's active session history entry's document state's document to null.
if (navigable()) {