system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-02 06:04:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS/Bytecode: Cache a base pointer to executable constants

Browse source 
Instead of fetching it from the current executable whenever we fetch a
constant, just keep a base pointer to the constants array handy.
This commit is contained in:
Andreas Kling 2024-05-10 07:44:16 +02:00 committed by Alexander Kalenik
parent 810a297626
commit 8eccfdb98c
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -155,11 +155,11 @@ ALWAYS_INLINE Value Interpreter::get(Operand op) const
{
switch (op.type()) {
case Operand::Type::Register:
return reg(Register { op.index() });
return m_registers.data()[op.index()];
case Operand::Type::Local:
return m_locals.data()[op.index()];
case Operand::Type::Constant:
return current_executable().constants[op.index()];
return m_constants.data()[op.index()];
}
__builtin_unreachable();
}
@ -168,13 +168,13 @@ ALWAYS_INLINE void Interpreter::set(Operand op, Value value)
{
switch (op.type()) {
case Operand::Type::Register:
reg(Register { op.index() }) = value;
m_registers.data()[op.index()] = value;
return;
case Operand::Type::Local:
m_locals.data()[op.index()] = value;
return;
case Operand::Type::Constant:
VERIFY_NOT_REACHED();
break;
}
__builtin_unreachable();
}
@ -720,6 +720,7 @@ Interpreter::ResultAndReturnRegister Interpreter::run_executable(Executable& exe
TemporaryChange restore_registers { m_registers, running_execution_context.registers.span() };
TemporaryChange restore_locals { m_locals, running_execution_context.locals.span() };
TemporaryChange restore_constants { m_constants, executable.constants.span() };
reg(Register::accumulator()) = initial_accumulator_value;
reg(Register::return_value()) = {};

1
Userland/Libraries/LibJS/Bytecode/Interpreter.h
View file

@ -98,6 +98,7 @@ private:
Optional<size_t&> m_program_counter;
Span<Value> m_registers;
Span<Value> m_locals;
Span<Value> m_constants;
};
extern bool g_dump_bytecode;