system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 14:10:45 +00:00
Code Issues Projects Releases Wiki Activity

LibJS/JIT: Add fast path for number comparisons

Browse Source 
So far only less_than was using a fast path. This commits uses the same
path for less_than_equals, greater_than and greater_than_equals.
This commit is contained in:
Sebastian Bernauer 2023-11-07 22:31:00 +01:00 committed by Andreas Kling
parent ff81513634
commit 8eb9c2dc54
2 changed files with 53 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

93
Userland/Libraries/LibJS/JIT/Compiler.cpp
View File

@ -621,53 +621,54 @@ void Compiler::compile_mul(Bytecode::Op::Mul const& op)
end.link(m_assembler);
}
static Value cxx_less_than(VM& vm, Value lhs, Value rhs)
{
return TRY_OR_SET_EXCEPTION(less_than(vm, lhs, rhs));
}
# define DO_COMPILE_COMPARISON_OP(TitleCaseName, snake_case_name, AssemblerCondition) \
static Value cxx_##snake_case_name(VM& vm, Value lhs, Value rhs) \
{ \
return TRY_OR_SET_EXCEPTION(snake_case_name(vm, lhs, rhs)); \
} \
\
void Compiler::compile_##snake_case_name(Bytecode::Op::TitleCaseName const& op) \
{ \
load_vm_register(ARG1, op.lhs()); \
load_accumulator(ARG2); \
\
Assembler::Label end {}; \
\
branch_if_both_int32(ARG1, ARG2, [&] { \
Assembler::Label true_case {}; \
\
m_assembler.sign_extend_32_to_64_bits(ARG1); \
m_assembler.sign_extend_32_to_64_bits(ARG2); \
\
m_assembler.jump_if( \
Assembler::Operand::Register(ARG1), \
Assembler::Condition::AssemblerCondition, \
Assembler::Operand::Register(ARG2), \
true_case); \
\
m_assembler.mov( \
Assembler::Operand::Register(GPR0), \
Assembler::Operand::Imm(Value(false).encoded())); \
store_accumulator(GPR0); \
m_assembler.jump(end); \
\
true_case.link(m_assembler); \
m_assembler.mov( \
Assembler::Operand::Register(GPR0), \
Assembler::Operand::Imm(Value(true).encoded())); \
store_accumulator(GPR0); \
\
m_assembler.jump(end); \
}); \
\
native_call((void*)cxx_##snake_case_name); \
store_accumulator(RET); \
check_exception(); \
end.link(m_assembler); \
}
void Compiler::compile_less_than(Bytecode::Op::LessThan const& op)
{
load_vm_register(ARG1, op.lhs());
load_accumulator(ARG2);
Assembler::Label end {};
branch_if_both_int32(ARG1, ARG2, [&] {
// if (ARG1 < ARG2) return true;
// else return false;
Assembler::Label true_case {};
m_assembler.sign_extend_32_to_64_bits(ARG1);
m_assembler.sign_extend_32_to_64_bits(ARG2);
m_assembler.jump_if(
Assembler::Operand::Register(ARG1),
Assembler::Condition::SignedLessThan,
Assembler::Operand::Register(ARG2),
true_case);
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Imm(Value(false).encoded()));
store_accumulator(GPR0);
m_assembler.jump(end);
true_case.link(m_assembler);
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Imm(Value(true).encoded()));
store_accumulator(GPR0);
m_assembler.jump(end);
});
native_call((void*)cxx_less_than);
store_accumulator(RET);
check_exception();
end.link(m_assembler);
}
JS_ENUMERATE_COMPARISON_OPS(DO_COMPILE_COMPARISON_OP)
# undef DO_COMPILE_COMPARISON_OP
static Value cxx_bitwise_and(VM& vm, Value lhs, Value rhs)
{

9
Userland/Libraries/LibJS/JIT/Compiler.h
View File

@ -48,14 +48,17 @@ private:
O(Mod, mod) \
O(In, in) \
O(InstanceOf, instance_of) \
O(GreaterThan, greater_than) \
O(GreaterThanEquals, greater_than_equals) \
O(LessThanEquals, less_than_equals) \
O(LooselyInequals, abstract_inequals) \
O(LooselyEquals, abstract_equals) \
O(StrictlyInequals, typed_inequals) \
O(StrictlyEquals, typed_equals)
# define JS_ENUMERATE_COMPARISON_OPS(O) \
O(LessThan, less_than, SignedLessThan) \
O(LessThanEquals, less_than_equals, SignedLessThanOrEqualTo) \
O(GreaterThan, greater_than, SignedGreaterThan) \
O(GreaterThanEquals, greater_than_equals, SignedGreaterThanOrEqualTo)
# define JS_ENUMERATE_NEW_BUILTIN_ERROR_BYTECODE_OPS(O) \
O(NewTypeError, new_type_error, TypeError)