system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 02:26:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibJS: Optimize insertion order in the Exception constructor

Browse source 
By inserting the stack frames in the correct order we can improve the
runtime for the test-js test suite by about 20%.
This commit is contained in:
Gunnar Beutner 2021-06-03 12:43:38 +02:00 committed by Linus Groh
parent bc8d16ad28
commit 8b449214af
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibJS/Runtime/Exception.cpp
View file

@ -18,18 +18,18 @@ Exception::Exception(Value value)
{
auto& vm = this->vm();
m_traceback.ensure_capacity(vm.call_stack().size());
for (auto* call_frame : vm.call_stack()) {
for (ssize_t i = vm.call_stack().size() - 1; i >= 0; i--) {
auto* call_frame = vm.call_stack()[i];
auto function_name = call_frame->function_name;
if (function_name.is_empty())
function_name = "<anonymous>";
m_traceback.prepend({
.function_name = move(function_name),
m_traceback.empend(
move(function_name),
// We might not have an AST node associated with the call frame, e.g. in promise
// reaction jobs (which aren't called anywhere from the source code).
// They're not going to generate any _unhandled_ exceptions though, so a meaningless
// source range is fine.
.source_range = call_frame->current_node ? call_frame->current_node->source_range() : SourceRange {},
});
call_frame->current_node ? call_frame->current_node->source_range() : SourceRange {});
}
}