system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 00:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use (transformed) path bounding quad for SVG path hit testing

Browse source 
This is needed for hit testing the directional arrows on the Street
View office tour, and generally makes SVG hit testing more precise.

Note: The rough bounding box is hit test first, so this should not
be a load more overhead.
This commit is contained in:
MacDue 2023-04-10 12:35:33 +01:00 committed by Andreas Kling
parent d0496ae9b8
commit 809c15d1ee
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/Painting/SVGGeometryPaintable.cpp
View file

@ -27,6 +27,19 @@ Layout::SVGGeometryBox const& SVGGeometryPaintable::layout_box() const
return static_cast<Layout::SVGGeometryBox const&>(layout_node());
}
Optional<HitTestResult> SVGGeometryPaintable::hit_test(CSSPixelPoint position, HitTestType type) const
{
auto result = SVGGraphicsPaintable::hit_test(position, type);
if (!result.has_value())
return {};
auto& geometry_element = layout_box().dom_node();
auto transformed_bounding_box = layout_box().layout_transform().map_to_quad(
const_cast<SVG::SVGGeometryElement&>(geometry_element).get_path().bounding_box());
if (!transformed_bounding_box.contains(position.to_type<float>()))
return {};
return result;
}
void SVGGeometryPaintable::paint(PaintContext& context, PaintPhase phase) const
{
if (!is_visible())

2
Userland/Libraries/LibWeb/Painting/SVGGeometryPaintable.h
View file

@ -17,6 +17,8 @@ class SVGGeometryPaintable final : public SVGGraphicsPaintable {
public:
static JS::NonnullGCPtr<SVGGeometryPaintable> create(Layout::SVGGeometryBox const&);
virtual Optional<HitTestResult> hit_test(CSSPixelPoint, HitTestType) const override;
virtual void paint(PaintContext&, PaintPhase) const override;
Layout::SVGGeometryBox const& layout_box() const;