system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 10:05:32 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

CMake: Link with -Bsymbolic-non-weak-functions if supported

Browse source 
This flag makes the linker bind default-visibility functions locally, so
that calls to them do not have to go through the PLT. This makes it
impossible to override them by preloading a DSO. This was already the
case partially due to `-fno-semantic-interposition`, however that flag
is only able to optimize call sites that are in the same Translation
Unit as the function definitions.

This removes 80% of the PLT relocations in `libjs.so.serenity`.

Obsoletes #20877
This commit is contained in:
Daniel Bertalan 2023-09-10 22:09:22 +02:00
parent 1f747b9132
commit 6fd8f9ea51
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Meta/CMake/lagom_compile_options.cmake
View file

@ -20,3 +20,7 @@ function(add_linker_flag_if_supported flag)
endfunction()
add_linker_flag_if_supported(LINKER:--gdb-index)
if (NOT ENABLE_FUZZERS)
add_linker_flag_if_supported(LINKER:-Bsymbolic-non-weak-functions)
endif()

2
Meta/CMake/serenity_compile_options.cmake
View file

@ -29,6 +29,8 @@ add_compile_options(-g1)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
add_link_options(LINKER:-Bsymbolic-non-weak-functions)
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
add_compile_options(-Wno-maybe-uninitialized)
add_compile_options(-Wcast-align)