system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 00:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

FileManager: Remove one direct call to FileSystemModel from outside

Browse source 
We should stop accessing the FileSystemModel outside DirectoryView.
This whole app is pretty badly factored, due to LibGUI being in its
infancy while it first developed.
This commit is contained in:
Andreas Kling 2020-08-12 20:27:23 +02:00
parent aae296ef08
commit 6caaa2bfdb
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Applications/FileManager/DirectoryView.cpp
View file

@ -355,3 +355,8 @@ void DirectoryView::update_statusbar()
set_status_message(builder.to_string());
}
void DirectoryView::set_should_show_dotfiles(bool show_dotfiles)
{
m_model->set_should_show_dotfiles(show_dotfiles);
}

2
Applications/FileManager/DirectoryView.h
View file

@ -110,6 +110,8 @@ public:
callback(*m_columns_view);
}
void set_should_show_dotfiles(bool);
GUI::FileSystemModel& model() { return *m_model; }
private:

2
Applications/FileManager/main.cpp
View file

@ -678,7 +678,7 @@ int run_in_windowed_mode(RefPtr<Core::ConfigFile> config, String initial_locatio
view_menu.add_action(*view_as_columns_action);
view_menu.add_separator();
view_menu.add_action(GUI::Action::create_checkable("Show dotfiles", { Mod_Ctrl, Key_H }, [&](auto& action) {
directory_view.model().set_should_show_dotfiles(action.is_checked());
directory_view.set_should_show_dotfiles(action.is_checked());
}));
auto& go_menu = menubar->add_menu("Go");