system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Remove a redundant double find-call in HashMap::ensure

Browse source 
If the value was found there's no reason to search for it again.
This commit is contained in:
Idan Horowitz 2021-09-10 01:41:40 +03:00
parent 706323beb1
commit 679bde06ed
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
AK/HashMap.h
View file

@ -134,8 +134,10 @@ public:
V& ensure(const K& key)
{
auto it = find(key);
if (it == end())
set(key, V());
if (it != end())
return it->value;
auto result = set(key, V());
VERIFY(result == HashSetResult::InsertedNewEntry);
return find(key)->value;
}
@ -143,9 +145,10 @@ public:
V& ensure(K const& key, Callback initialization_callback)
{
auto it = find(key);
if (it == end()) {
set(key, initialization_callback());
}
if (it != end())
return it->value;
auto result = set(key, initialization_callback());
VERIFY(result == HashSetResult::InsertedNewEntry);
return find(key)->value;
}