system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-18 13:53:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Ext2FS: Don't reload already-cached block list when freeing inode"

Browse source 
This reverts commit 1e737a5c50.

The cached block list does not include meta-blocks, so we'd end up
leaking those. There's definitely a nice way to avoid work here, but it
turns out it wasn't quite this trivial. Reverting for now.
This commit is contained in:
Andreas Kling 2021-02-26 14:57:00 +01:00
parent 79889ef052
commit 65e083ed36
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -543,10 +543,8 @@ void Ext2FS::free_inode(Ext2FSInode& inode)
dbgln_if(EXT2_DEBUG, "Ext2FS: Inode {} has no more links, time to delete!", inode.index());
// Mark all blocks used by this inode as free.
if (inode.m_block_list.is_empty())
inode.m_block_list = block_list_for_inode(inode.m_raw_inode, true);
for (auto block_index : inode.m_block_list) {
auto block_list = block_list_for_inode(inode.m_raw_inode, true);
for (auto block_index : block_list) {
VERIFY(block_index <= super_block().s_blocks_count);
if (block_index.value()) {
auto result = set_block_allocation_state(block_index, false);