system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 08:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Kernel: Prevent VMWareMouseDevice from handling invalid mouse packets"

Browse source 
This reverts commit 4131b35851.

We're swallowing way too many mouse events from QEMU with this code
enabled. Something is not right, so let's revert it for now.
This commit is contained in:
Andreas Kling 2021-11-03 16:48:42 +01:00
parent 82d7934959
commit 652042e680
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Devices/HID/VMWareMouseDevice.cpp
View file

@ -25,11 +25,10 @@ UNMAP_AFTER_INIT RefPtr<VMWareMouseDevice> VMWareMouseDevice::try_to_initialize(
return {};
}
void VMWareMouseDevice::irq_handle_byte_read(u8 byte)
void VMWareMouseDevice::irq_handle_byte_read(u8)
{
VERIFY(VMWareBackdoor::the());
VERIFY(VMWareBackdoor::the()->vmmouse_is_absolute());
// We won't receive complete packets with the backdoor enabled,
// we will only get one byte for each event, which we'll just
// discard. If we were to wait until we *think* that we got a
@ -37,12 +36,6 @@ void VMWareMouseDevice::irq_handle_byte_read(u8 byte)
// because we wouldn't read the appropriate number of mouse
// packets from VMWareBackdoor.
auto mouse_packet = VMWareBackdoor::the()->receive_mouse_packet();
// Only process packets with bit 3 set.
// Note that this needs to happen _after_ invoking receive_mouse_packet() above
if (!(byte & 0x8))
return;
if (mouse_packet.has_value()) {
m_entropy_source.add_random_event(mouse_packet.value());
{