system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 18:46:18 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibCore: Fix race conditions in TestLibCoreStream

Browse source 
It was possible for the "local_socket_read" and "local_socket_write"
tests to fail because we had exited the EventLoop before
BackgroundAction got around to invoking the completion callback.

The crash happened when trying to deferred_invoke() on the background
thread, calling Core::EventLoop::current() after said EventLoop had
returned from exec().

Fix this by not passing a completion callback, since we didn't need
one in the first place.
This commit is contained in:
Andreas Kling 2021-12-28 00:59:15 +01:00
parent bdd2dba77b
commit 5d55a42ded
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Tests/LibCore/TestLibCoreStream.cpp
View file

@ -333,7 +333,7 @@ TEST_CASE(local_socket_read)
return 0;
},
[](int) {});
nullptr);
event_loop.exec();
::unlink("/tmp/test-socket");
@ -372,7 +372,7 @@ TEST_CASE(local_socket_write)
return 0;
},
[](int) {});
nullptr);
event_loop.exec();
::unlink("/tmp/test-socket");