system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 12:23:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

CrashReporter: Dispatch backtrace progress callbacks on the main thread

Browse source 
We can't fiddle with GUI widgets off the main thread, so let's use
Core::EventLoop::deferred_invoke() to dispatch the work.

The progress bar doesn't visibly update yet, but at least we're not
crashing anymore.
This commit is contained in:
Andreas Kling 2022-01-25 08:53:46 +01:00
parent d1cea57246
commit 58b5aede65
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Userland/Applications/CrashReporter/main.cpp
View file

@ -297,10 +297,13 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
size_t thread_index = 0;
coredump->for_each_thread_info([&](auto& thread_info) {
results.thread_backtraces.append(build_backtrace(*coredump, thread_info, thread_index, [&](size_t frame_index, size_t frame_count) {
window->set_progress(100.0f * (float)(frame_index + 1) / (float)frame_count);
progressbar.set_value(frame_index + 1);
progressbar.set_max(frame_count);
Core::EventLoop::wake();
Core::EventLoop::with_main_locked([&](auto& main) {
main->deferred_invoke([&] {
window->set_progress(100.0f * (float)(frame_index + 1) / (float)frame_count);
progressbar.set_value(frame_index + 1);
progressbar.set_max(frame_count);
});
});
}));
results.thread_cpu_registers.append(build_cpu_registers(thread_info, thread_index));
++thread_index;